| commit | 85ddbd9324c2e103e60b7b4c5e79a4c6683dcb2b | |
| author | Alma Thaler <almathaler@fb.com> | |
| Wed, 3 Aug 2022 17:41:28 +0000 (3 10:41 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 3 Aug 2022 17:41:28 +0000 (3 10:41 -0700) | ||
| tree | 60434790d6844c4a8e54e85a7103467122fff4c7 | treesnapshot (tar.gz zip) |
| parent | b68764fab90357269fc86c0faadb0f5d9d570d5b | commitdiff |
Perf Improvements/Cleanup : TypedValue Deserializer
Summary:
Undoes D37897883 (https://github.com/facebook/hhvm/commit/ca17b7ce6319ae118d3cb8a3a9bf42b5656527fa)
Instead of re-invoking `regex` to parse TypedValues, deserialize instead.
```
buck2 run @//mode/opt :hackc -- verify assemble ~/www
```
Previously took 914.658s
Now takes 848.133s
Should be a much bigger speed up when implementing deserializer for main tokenizer
Future todo:
-- Deserializer for under-the-hood of main tokenizer
-- Code cleanup
Reviewed By: aorenste
Differential Revision: D38180337
fbshipit-source-id: 7234888099ebf3189567c9083aef5b99599c07a4
Summary:
Undoes D37897883 (https://github.com/facebook/hhvm/commit/ca17b7ce6319ae118d3cb8a3a9bf42b5656527fa)
Instead of re-invoking `regex` to parse TypedValues, deserialize instead.
```
buck2 run @//mode/opt :hackc -- verify assemble ~/www
```
Previously took 914.658s
Now takes 848.133s
Should be a much bigger speed up when implementing deserializer for main tokenizer
Future todo:
-- Deserializer for under-the-hood of main tokenizer
-- Code cleanup
Reviewed By: aorenste
Differential Revision: D38180337
fbshipit-source-id: 7234888099ebf3189567c9083aef5b99599c07a4
| hphp/hack/src/hackc/hackc/assemble.rs | diffblobblamehistory |