| commit | 85b08f978704caabd3990ec86656c54d35aa6029 | |
| author | Waleed Khan <waleedk@fb.com> | |
| Wed, 18 Mar 2020 23:33:42 +0000 (18 16:33 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 18 Mar 2020 23:37:47 +0000 (18 16:37 -0700) | ||
| tree | 49dcf5575782fbd4f2c0b0a1a96df2acb2a07636 | treesnapshot (tar.gz zip) |
| parent | 3629f1ef8357cdd31fd563c0b540a7fab9fa2756 | commitdiff |
Thread `Provider_context.t` through `ServerFindLocals`
Summary:
`ServerFindLocals` is responsible for finding references to a local variable. This powers scenarios such as document-highlights and rename.
Currently, we do a re-parse of the file for every invocation. Document-highlights is one of the most frequent IDE actions taken (since it happens whenever you click anywhere in the document), so that's probably been adding several milliseconds of latency that keeps queueing up.
Switch this to use provider contexts so that we cache the AST that we're using between IDE requests for the same file.
Reviewed By: ljw1004
Differential Revision: D20518728
fbshipit-source-id: 548d3ac349eb2cf3c7f9f319ad3502dd59450d8c
Summary:
`ServerFindLocals` is responsible for finding references to a local variable. This powers scenarios such as document-highlights and rename.
Currently, we do a re-parse of the file for every invocation. Document-highlights is one of the most frequent IDE actions taken (since it happens whenever you click anywhere in the document), so that's probably been adding several milliseconds of latency that keeps queueing up.
Switch this to use provider contexts so that we cache the AST that we're using between IDE requests for the same file.
Reviewed By: ljw1004
Differential Revision: D20518728
fbshipit-source-id: 548d3ac349eb2cf3c7f9f319ad3502dd59450d8c