| commit | 853a630a026f2749a47c5a530bf83027beb06c7c | |
| author | Max Heiber <mheiber@fb.com> | |
| Fri, 5 Aug 2022 13:23:47 +0000 (5 06:23 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 5 Aug 2022 13:23:47 +0000 (5 06:23 -0700) | ||
| tree | 5c73dbec86ecce781b41639013ebc31870cb13eb | treesnapshot (tar.gz zip) |
| parent | 8f675d1743322c2e10a8af3b50c18a00ce1292a5 | commitdiff |
Remove `if self.is_type_checker` check
Summary:
follow-up to D38082663 (https://github.com/facebook/hhvm/commit/f2bac8caaa25e1b3711efa45769c74fef5a133f3)
What:
- remove a check that we're in the type checker rather than hackc. iuc users won't notice the difference unless they are running hhvm without hh, in which case more readonly violations will be caught.
Why:
- We use `if self.is_type_checker` to ensure we roll out changes to the type-checker before hackc. I suspect the type-checker change is deployed, since D38082663 (https://github.com/facebook/hhvm/commit/f2bac8caaa25e1b3711efa45769c74fef5a133f3) landed ~1 week ago.
Reviewed By: viratyosin
Differential Revision: D38387657
fbshipit-source-id: b2af393f1dd890db92146fc6fd1f3bb4e5774465
Summary:
follow-up to D38082663 (https://github.com/facebook/hhvm/commit/f2bac8caaa25e1b3711efa45769c74fef5a133f3)
What:
- remove a check that we're in the type checker rather than hackc. iuc users won't notice the difference unless they are running hhvm without hh, in which case more readonly violations will be caught.
Why:
- We use `if self.is_type_checker` to ensure we roll out changes to the type-checker before hackc. I suspect the type-checker change is deployed, since D38082663 (https://github.com/facebook/hhvm/commit/f2bac8caaa25e1b3711efa45769c74fef5a133f3) landed ~1 week ago.
Reviewed By: viratyosin
Differential Revision: D38387657
fbshipit-source-id: b2af393f1dd890db92146fc6fd1f3bb4e5774465
| hphp/hack/src/parser/readonly_check.rs | diffblobblamehistory |