Fix tests prior to removing AAWH::fromDarray and ::fromVarray
commit81ea96da04b405eccc4aac3a4580cabe21d401f3
authorAlexey Toptygin <alexeyt@fb.com>
Sat, 19 Mar 2022 19:55:43 +0000 (19 12:55 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Sat, 19 Mar 2022 19:55:43 +0000 (19 12:55 -0700)
treec97f6cbd1da8b29175c479206ab32fa2fe6e9c75
parent1221bca729d1440d29161f8d94641bc8cb83d508
Fix tests prior to removing AAWH::fromDarray and ::fromVarray

Summary:
Some tests were deleted:
hphp/test/slow/dv_array/await_all_from_varray.php and hphp/test/slow/dv_array_hack_arr/await_all_from_varray.php doesn't do anything that we don't have other tests covering for AAWH::fromVec
hphp/test/slow/async/streams/socket-pair.php.disabled has been disabled for a long time, and there is no way to safely re-enable it (it wants to be able to listen on a port, which is inherently racy in unit tests); just delete it instead.

hphp/test/slow/hack_arr_compat/gena.php was brought up to date with www

The remaining tests had ::fromVarray/::fromDarray parts either deleted (if they duplicate other parts testing ::fromVec/::fromDict) or converted to ::fromVec/::fromDict if they aren't duplicates.

Reviewed By: jano

Differential Revision: D34818480

fbshipit-source-id: 9d4ad336237c898934fed0c3751bdd92e4c1e8f7
15 files changed:
hphp/test/slow/async/awaitall.php
hphp/test/slow/async/awaitall.php.expect
hphp/test/slow/async/reschedule.php
hphp/test/slow/async/streams/socket-pair.php.disabled [deleted file]
hphp/test/slow/async/streams/socket-pair.php.expect [deleted file]
hphp/test/slow/dv_array/await_all_from_varray.php [deleted file]
hphp/test/slow/dv_array/await_all_from_varray.php.expect [deleted file]
hphp/test/slow/dv_array/ext_xenon/xenon.php
hphp/test/slow/dv_array/ext_xenon/xenon_crash.php
hphp/test/slow/dv_array_hack_arr/await_all_from_varray.php [deleted file]
hphp/test/slow/dv_array_hack_arr/await_all_from_varray.php.expect [deleted file]
hphp/test/slow/dv_array_hack_arr/ext_xenon/xenon.php
hphp/test/slow/dv_array_hack_arr/ext_xenon/xenon_crash.php
hphp/test/slow/hack_arr_compat/gena.php
hphp/test/slow/hack_arr_compat/gena.php.hphp_opts [deleted file]