| commit | 809ed8e7ae993b1eb14ca3db7d7c3b94a7ce02bf | |
| author | Kasper Kopec <kasper@fb.com> | |
| Sat, 19 Mar 2016 00:51:29 +0000 (18 17:51 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Sat, 19 Mar 2016 01:00:43 +0000 (18 18:00 -0700) | ||
| tree | ad87ba9d2cb33b27bed41630278d6f9dad92db41 | treesnapshot (tar.gz zip) |
| parent | 64f20d4bb04a83a0c4c140ade5324047e971664d | commitdiff |
Use Marshal_tools instead of channels to avoid buffering
Summary:Channels + Unix.select () = bad times because of buffering inside of channels that file descriptors are unaware of.
peterhal: I think this is the source of the error you've been seeing in testing today,
Reviewed By: int3
Differential Revision: D3072369
fb-gh-sync-id: 7c2e5637fe296f98a7ab0af9ebcf19d5dfcd7089
shipit-source-id: 7c2e5637fe296f98a7ab0af9ebcf19d5dfcd7089
Summary:Channels + Unix.select () = bad times because of buffering inside of channels that file descriptors are unaware of.
peterhal: I think this is the source of the error you've been seeing in testing today,
Reviewed By: int3
Differential Revision: D3072369
fb-gh-sync-id: 7c2e5637fe296f98a7ab0af9ebcf19d5dfcd7089
shipit-source-id: 7c2e5637fe296f98a7ab0af9ebcf19d5dfcd7089
| hphp/hack/src/client/clientIde.ml | diffblobblamehistory | |
| hphp/hack/src/server/ideMain.ml | diffblobblamehistory |