| commit | 7f4b85b28ed4e7884ac3fe730dee3e840624a3a5 | |
| author | Neal Poole <neal@fb.com> | |
| Thu, 3 Nov 2016 19:51:56 +0000 (3 12:51 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Thu, 3 Nov 2016 20:08:27 +0000 (3 13:08 -0700) | ||
| tree | b49e7b5213f02908184eb3537a91303c7e8ac40d | treesnapshot (tar.gz zip) |
| parent | 84c871d858f3eed72eb9db0261ea592087397c25 | commitdiff |
Stop calling curl_easy_reset when running curl_init
Summary: We would call `curl_easy_reset` every time the PHP function `curl_init` is called. This behavior is inconsistent with upstream PHP and causes test failures with the latest libcurl (arguably due to a bug there). Lets make the behavior consistent by factoring out the call to `curl_easy_reset`.
Reviewed By: swtaarrs
Differential Revision: D4124700
fbshipit-source-id: 9a9f858b4be670ce397641cf699b3f2ee916d71a
Summary: We would call `curl_easy_reset` every time the PHP function `curl_init` is called. This behavior is inconsistent with upstream PHP and causes test failures with the latest libcurl (arguably due to a bug there). Lets make the behavior consistent by factoring out the call to `curl_easy_reset`.
Reviewed By: swtaarrs
Differential Revision: D4124700
fbshipit-source-id: 9a9f858b4be670ce397641cf699b3f2ee916d71a
| hphp/runtime/ext/curl/curl-resource.cpp | diffblobblamehistory | |
| hphp/runtime/ext/curl/curl-resource.h | diffblobblamehistory |