| commit | 7f37ef970b54f552103dae52a72ea1ec1e301d65 | |
| author | Kendall Hopkins <kendallhopkins@fb.com> | |
| Sat, 18 May 2019 06:12:48 +0000 (17 23:12 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Sat, 18 May 2019 06:17:38 +0000 (17 23:17 -0700) | ||
| tree | b652c033d9b731c75571703dbeed4bc2be2bceb2 | treesnapshot (tar.gz zip) |
| parent | fbdcd57d990f8f63c17f417b7d6699037cddd247 | commitdiff |
Convert exceptions from FFP errors into a Parser error.
Summary:
Today if we throw an exception during `full_fidelity_parser_errors.ml` we will eat the error and report `No Errors` in typechecking and log ```Warning, lowering failed for ... - error: (Failure xxx)``` to the log file no one looks at. This is deeply troubling on many levels.
This diff forces these errors to be reported as `UNEXPECTED_ERROR` with the text of the exception. It won't be very helpful because we don't have a node to report it on, but at least it won't report no errors.
Reviewed By: Matt-Schellhas
Differential Revision: D15397439
fbshipit-source-id: 1fd5366e4a3bfdabe0fa84af7f0bee6035c5acb4
Summary:
Today if we throw an exception during `full_fidelity_parser_errors.ml` we will eat the error and report `No Errors` in typechecking and log ```Warning, lowering failed for ... - error: (Failure xxx)``` to the log file no one looks at. This is deeply troubling on many levels.
This diff forces these errors to be reported as `UNEXPECTED_ERROR` with the text of the exception. It won't be very helpful because we don't have a node to report it on, but at least it won't report no errors.
Reviewed By: Matt-Schellhas
Differential Revision: D15397439
fbshipit-source-id: 1fd5366e4a3bfdabe0fa84af7f0bee6035c5acb4
| hphp/hack/src/parser/full_fidelity_parser_errors.ml | diffblobblamehistory |