Remove "let" experiment
commit7e22315e3d4ff335cbf1c07d7cf5843c9c06fe2e
authorKasper Kopec <kasper@fb.com>
Tue, 19 Nov 2019 22:36:58 +0000 (19 14:36 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 19 Nov 2019 22:40:46 +0000 (19 14:40 -0800)
treedcd6191041359fb07c708a78268db99df4681e70
parentda7724c479a4d32aa0542f7438e26e76def371f4
Remove "let" experiment

Summary:
Doesn't look like it's going to happen, it was under disabled flag for many months by now.

let_it_go

Reviewed By: Wilfred

Differential Revision: D18525850

fbshipit-source-id: a4d55180b89fffaefa11cbf580930f1f5ee625e1
249 files changed:
hphp/hack/src/annotated_ast/aast.ml
hphp/hack/src/annotated_ast/ast_to_aast.ml
hphp/hack/src/ast/ast.ml
hphp/hack/src/decl/direct_decl_smart_constructors_generated.rs
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/facts/facts_smart_constructors_generated.rs
hphp/hack/src/hackfmt/hack_format.ml
hphp/hack/src/hhbc/closure_convert.ml
hphp/hack/src/hhbc/emit_expression.ml
hphp/hack/src/hhbc/emit_property.ml
hphp/hack/src/hhbc/emit_statement.ml
hphp/hack/src/hhbc/jump_targets.ml
hphp/hack/src/naming/elaborate_namespaces_endo.ml
hphp/hack/src/naming/naming.ml
hphp/hack/src/naming/nast.ml
hphp/hack/src/oxidized/aast_visitor/node_impl_gen.rs
hphp/hack/src/oxidized/aast_visitor/node_mut_impl_gen.rs
hphp/hack/src/oxidized/gen/aast.rs
hphp/hack/src/oxidized/impl_gen/aast_impl_gen.rs
hphp/hack/src/parser/coroutine_smart_constructors_generated.rs
hphp/hack/src/parser/decl_mode_smart_constructors_generated.rs
hphp/hack/src/parser/flatten_smart_constructors.rs
hphp/hack/src/parser/full_fidelity_ast.ml
hphp/hack/src/parser/full_fidelity_syntax.ml
hphp/hack/src/parser/full_fidelity_syntax_kind.ml
hphp/hack/src/parser/full_fidelity_syntax_type.ml
hphp/hack/src/parser/full_fidelity_token_kind.ml
hphp/hack/src/parser/full_fidelity_validated_syntax.ml
hphp/hack/src/parser/js/full_fidelity_schema.json
hphp/hack/src/parser/lexer.rs
hphp/hack/src/parser/lowerer.rs
hphp/hack/src/parser/minimal_smart_constructors.rs
hphp/hack/src/parser/ocaml_syntax_generated.rs
hphp/hack/src/parser/positioned_smart_constructors.rs
hphp/hack/src/parser/rust_parser_errors.rs
hphp/hack/src/parser/schema/full_fidelity_schema.ml
hphp/hack/src/parser/schema/schema_definition.ml
hphp/hack/src/parser/schema/token_schema_definition.ml
hphp/hack/src/parser/smart_constructors_generated.rs
hphp/hack/src/parser/smart_constructors_wrappers.rs
hphp/hack/src/parser/statement_parser.rs
hphp/hack/src/parser/syntax_generated.rs
hphp/hack/src/parser/syntax_kind.rs
hphp/hack/src/parser/syntax_sig.ml
hphp/hack/src/parser/syntax_smart_constructors_generated.rs
hphp/hack/src/parser/syntax_type.rs
hphp/hack/src/parser/token_kind.rs
hphp/hack/src/parser/verify_smart_constructors_generated.rs
hphp/hack/src/typing/nastInitCheck.ml
hphp/hack/src/typing/tast_typecheck.ml
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_get_locals.ml
hphp/hack/test/hackfmt/tests/let_statement.php [deleted file]
hphp/hack/test/hackfmt/tests/let_statement.php.exp [deleted file]
hphp/hack/test/rust/rust_ocaml_test.ml
hphp/hack/test/typecheck/immutable_binding/HH_FLAGS [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_mutation.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_mutation.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_scope.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_scope.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_scope_2.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_scope_2.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_scope_3.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_scope_3.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_shadowing.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_shadowing.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_shadowing_2.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_shadowing_2.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_shadowing_3.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_catch_shadowing_3.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach_mutation.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach_mutation.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach_scope.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach_scope.php.exp [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach_shadow.php [deleted file]
hphp/hack/test/typecheck/immutable_binding/immutable_foreach_shadow.php.exp [deleted file]
hphp/hack/test/typecheck/let/HH_FLAGS [deleted file]
hphp/hack/test/typecheck/let/let_always_execute_block.php [deleted file]
hphp/hack/test/typecheck/let/let_always_execute_block.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_assign.php [deleted file]
hphp/hack/test/typecheck/let/let_assign.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_await.php [deleted file]
hphp/hack/test/typecheck/let/let_await.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_closure.php [deleted file]
hphp/hack/test/typecheck/let/let_closure.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_declaration_only.php [deleted file]
hphp/hack/test/typecheck/let/let_declaration_only.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_do_in_cond.php [deleted file]
hphp/hack/test/typecheck/let/let_do_in_cond.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_do_in_cond_shadow.php [deleted file]
hphp/hack/test/typecheck/let/let_do_in_cond_shadow.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_do_while.php [deleted file]
hphp/hack/test/typecheck/let/let_do_while.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_do_while_shadowing.php [deleted file]
hphp/hack/test/typecheck/let/let_do_while_shadowing.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_for.php [deleted file]
hphp/hack/test/typecheck/let/let_for.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_for_cond.php [deleted file]
hphp/hack/test/typecheck/let/let_for_cond.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_for_iter.php [deleted file]
hphp/hack/test/typecheck/let/let_for_iter.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_for_shadowing.php [deleted file]
hphp/hack/test/typecheck/let/let_for_shadowing.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_foreach.php [deleted file]
hphp/hack/test/typecheck/let/let_foreach.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_foreach_2.php [deleted file]
hphp/hack/test/typecheck/let/let_foreach_2.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_foreach_kv.php [deleted file]
hphp/hack/test/typecheck/let/let_foreach_kv.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_foreach_kv_2.php [deleted file]
hphp/hack/test/typecheck/let/let_foreach_kv_2.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_capture.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_capture.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_capture_shadow.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_capture_shadow.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error.php.legacy.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error2.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error2.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error3.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error3.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error4.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_error4.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_hof.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_hof.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_hof.php.legacy.exp [deleted file]
hphp/hack/test/typecheck/let/let_lambda_nest.php [deleted file]
hphp/hack/test/typecheck/let/let_lambda_nest.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_out_of_scope.php [deleted file]
hphp/hack/test/typecheck/let/let_out_of_scope.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_refine.php [deleted file]
hphp/hack/test/typecheck/let/let_refine.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_return.php [deleted file]
hphp/hack/test/typecheck/let/let_return.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_return_error.php [deleted file]
hphp/hack/test/typecheck/let/let_return_error.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_return_subtype.php [deleted file]
hphp/hack/test/typecheck/let/let_return_subtype.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_return_subtype_2.php [deleted file]
hphp/hack/test/typecheck/let/let_return_subtype_2.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_same_scope_shadowing.php [deleted file]
hphp/hack/test/typecheck/let/let_same_scope_shadowing.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_scoped_shadowing.php [deleted file]
hphp/hack/test/typecheck/let/let_scoped_shadowing.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_subtype.php [deleted file]
hphp/hack/test/typecheck/let/let_subtype.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_subtype_2.php [deleted file]
hphp/hack/test/typecheck/let/let_subtype_2.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_subtype_covariance.php [deleted file]
hphp/hack/test/typecheck/let/let_subtype_covariance.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_subtype_error.php [deleted file]
hphp/hack/test/typecheck/let/let_subtype_error.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_switch.php [deleted file]
hphp/hack/test/typecheck/let/let_switch.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_switch_2.php [deleted file]
hphp/hack/test/typecheck/let/let_switch_2.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_try_catch.php [deleted file]
hphp/hack/test/typecheck/let/let_try_catch.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_try_catch_finally.php [deleted file]
hphp/hack/test/typecheck/let/let_try_catch_finally.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_try_finally.php [deleted file]
hphp/hack/test/typecheck/let/let_try_finally.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_type_error.php [deleted file]
hphp/hack/test/typecheck/let/let_type_error.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_type_hint.php [deleted file]
hphp/hack/test/typecheck/let/let_type_hint.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_type_hint_error.php [deleted file]
hphp/hack/test/typecheck/let/let_type_hint_error.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_type_hint_shadowed_same_scope.php [deleted file]
hphp/hack/test/typecheck/let/let_type_hint_shadowed_same_scope.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_type_scope.php [deleted file]
hphp/hack/test/typecheck/let/let_type_scope.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_using.php [deleted file]
hphp/hack/test/typecheck/let/let_using.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_while.php [deleted file]
hphp/hack/test/typecheck/let/let_while.php.exp [deleted file]
hphp/hack/test/typecheck/let/let_while_shadowing.php [deleted file]
hphp/hack/test/typecheck/let/let_while_shadowing.php.exp [deleted file]
hphp/test/slow/config-override/hacksperimental.php
hphp/test/slow/config-override/hacksperimental.php.expect
hphp/test/slow/config-override/hacksperimental.php.expect-repo
hphp/test/slow/immutable_binding/catch_1.php [deleted file]
hphp/test/slow/immutable_binding/catch_1.php.expect [deleted file]
hphp/test/slow/immutable_binding/catch_2.php [deleted file]
hphp/test/slow/immutable_binding/catch_2.php.expect [deleted file]
hphp/test/slow/immutable_binding/catch_no_leak.php [deleted file]
hphp/test/slow/immutable_binding/catch_no_leak.php.expect [deleted file]
hphp/test/slow/immutable_binding/catch_shadow_1.php [deleted file]
hphp/test/slow/immutable_binding/catch_shadow_1.php.expect [deleted file]
hphp/test/slow/immutable_binding/catch_shadow_2.php [deleted file]
hphp/test/slow/immutable_binding/catch_shadow_2.php.expect [deleted file]
hphp/test/slow/immutable_binding/config.ini [deleted file]
hphp/test/slow/immutable_binding/foreach_1.php [deleted file]
hphp/test/slow/immutable_binding/foreach_1.php.expect [deleted file]
hphp/test/slow/immutable_binding/foreach_2.php [deleted file]
hphp/test/slow/immutable_binding/foreach_2.php.expect [deleted file]
hphp/test/slow/immutable_binding/foreach_3.php [deleted file]
hphp/test/slow/immutable_binding/foreach_3.php.expect [deleted file]
hphp/test/slow/immutable_binding/foreach_4.php [deleted file]
hphp/test/slow/immutable_binding/foreach_4.php.expect [deleted file]
hphp/test/slow/immutable_binding/foreach_no_leak.php [deleted file]
hphp/test/slow/immutable_binding/foreach_no_leak.php.expect [deleted file]
hphp/test/slow/immutable_binding/foreach_shadow.php [deleted file]
hphp/test/slow/immutable_binding/foreach_shadow.php.expect [deleted file]
hphp/test/slow/immutable_binding/hphp_config.ini [deleted file]
hphp/test/slow/let_statement/config.ini [deleted file]
hphp/test/slow/let_statement/do_loop.php [deleted file]
hphp/test/slow/let_statement/do_loop.php.expect [deleted file]
hphp/test/slow/let_statement/do_loop_cond.php [deleted file]
hphp/test/slow/let_statement/do_loop_cond.php.expect [deleted file]
hphp/test/slow/let_statement/for_loop.php [deleted file]
hphp/test/slow/let_statement/for_loop.php.expect [deleted file]
hphp/test/slow/let_statement/for_loop_cond.php [deleted file]
hphp/test/slow/let_statement/for_loop_cond.php.expect [deleted file]
hphp/test/slow/let_statement/for_loop_iterate.php [deleted file]
hphp/test/slow/let_statement/for_loop_iterate.php.expect [deleted file]
hphp/test/slow/let_statement/hphp_config.ini [deleted file]
hphp/test/slow/let_statement/lambda.php [deleted file]
hphp/test/slow/let_statement/lambda.php.expect [deleted file]
hphp/test/slow/let_statement/lambda2.php [deleted file]
hphp/test/slow/let_statement/lambda2.php.expect [deleted file]
hphp/test/slow/let_statement/lambda_capture.php [deleted file]
hphp/test/slow/let_statement/lambda_capture.php.expect [deleted file]
hphp/test/slow/let_statement/lambda_no_capture.php [deleted file]
hphp/test/slow/let_statement/lambda_no_capture.php.expect [deleted file]
hphp/test/slow/let_statement/let_var_arithmetic.php [deleted file]
hphp/test/slow/let_statement/let_var_arithmetic.php.expect [deleted file]
hphp/test/slow/let_statement/no_shadow.php [deleted file]
hphp/test/slow/let_statement/no_shadow.php.expect [deleted file]
hphp/test/slow/let_statement/shadow.php [deleted file]
hphp/test/slow/let_statement/shadow.php.expect [deleted file]
hphp/test/slow/let_statement/shadow_different_type.php [deleted file]
hphp/test/slow/let_statement/shadow_different_type.php.expect [deleted file]
hphp/test/slow/let_statement/switch.php [deleted file]
hphp/test/slow/let_statement/switch.php.expect [deleted file]
hphp/test/slow/let_statement/try_catch.php [deleted file]
hphp/test/slow/let_statement/try_catch.php.expect [deleted file]
hphp/test/slow/let_statement/while_loop.php [deleted file]
hphp/test/slow/let_statement/while_loop.php.expect [deleted file]
hphp/test/slow/let_statement/while_loop_shadow.php [deleted file]
hphp/test/slow/let_statement/while_loop_shadow.php.expect [deleted file]