Rename Set::difference() to Set::removeAll()
commit7ded25076f2cb5df73019af6d028e198f643ca92
authorDrew Paroski <andrewparoski@fb.com>
Tue, 14 Jan 2014 03:40:57 +0000 (13 19:40 -0800)
committerSara Golemon <sgolemon@fb.com>
Tue, 14 Jan 2014 19:41:34 +0000 (14 11:41 -0800)
tree2084be70031268196d466b7e5253e3631377644f
parenta464ad28e8f1e2eab7f4600ac982463edfbac596
Rename Set::difference() to Set::removeAll()

The difference method is confusingly named; its name does not imply that it
modifies the original Set. This diff renames "difference" to "removeAll" to
make it clearer. Eventually the difference() method will be removed after
all callers have been updated.

Reviewed By: @elgenie

Differential Revision: D1120227
hphp/runtime/ext/ext_collections.cpp
hphp/runtime/ext/ext_collections.h
hphp/system/idl/collections.idl.json