Make intish cast explicit for fql_multiparse_10
commit7dafea15c207e1dd49eeec59e6da20c49b1cc8e5
authorJoseph Griego <jgriego@fb.com>
Wed, 10 Oct 2018 16:05:17 +0000 (10 09:05 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Wed, 10 Oct 2018 16:13:30 +0000 (10 09:13 -0700)
tree18c50d1a32deda4c5ef63aed21fa15573b71bdbd
parent3399c15fa4066c6dfb38e0c2b10cb89c3547513d
Make intish cast explicit for fql_multiparse_10

Summary:
This extension is a source of intish cast. Make the intish casts explicit when we convert the result keys from std::string to arraykeys.

Note that this doesn't fix the attached task's repro which induces an implicit cast to array from the passed-in Map.

Reviewed By: mxw

Differential Revision: D10219443

fbshipit-source-id: c47c4bcf40d2e284fc8c3c7009bae641d7a7e6d7
hphp/test/slow/hack_arr_compat/fql_multiparse.php [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/fql_multiparse.php.expect [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/fql_multiparse.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/fql_multiparse.php.opts [new file with mode: 0644]