| commit | 7d98201943de283e50a39d6d72aca8f993f95693 | |
| author | Joseph Griego <jgriego@fb.com> | |
| Thu, 22 Aug 2019 20:59:41 +0000 (22 13:59 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 22 Aug 2019 21:01:20 +0000 (22 14:01 -0700) | ||
| tree | b24af7efbc4b31ccad43a21bc3979cb1e80e0dbc | treesnapshot (tar.gz zip) |
| parent | 698931391c505ba957b0461e3161c6e7a0f4ed8a | commitdiff |
Fix `provTagHere` to actually reference the srcLoc table
Summary:
Before, we'd shove in the _index_ to this table instead of consulting
it, which is .... not ideal. Trait flattening can mean that some of the
indicies can be -1 since their source unit differs from the function's
originalUnit; I don't think these will be a problem since we'd have seen
logging with line numbers of -1 already and we'll put up a diff to have this
generate a more coherent tag than `file:-1`.
Reviewed By: mxw
Differential Revision: D16954190
fbshipit-source-id: 7f31194826dbfe28ba1fe745dba69a7b7782ab2d
Summary:
Before, we'd shove in the _index_ to this table instead of consulting
it, which is .... not ideal. Trait flattening can mean that some of the
indicies can be -1 since their source unit differs from the function's
originalUnit; I don't think these will be a problem since we'd have seen
logging with line numbers of -1 already and we'll put up a diff to have this
generate a more coherent tag than `file:-1`.
Reviewed By: mxw
Differential Revision: D16954190
fbshipit-source-id: 7f31194826dbfe28ba1fe745dba69a7b7782ab2d
| hphp/hhbbc/interp-internal.h | diffblobblamehistory |