Let ElfFile open functions take Options
commit7c94a2f6240e3cb80564827748aafb314a6552cd
authorYedidya Feldblum <yfeldblum@fb.com>
Wed, 4 Dec 2019 21:57:39 +0000 (4 13:57 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 4 Dec 2019 21:59:51 +0000 (4 13:59 -0800)
treeee1dcce692c0713c09b6cbc264191a98f58beabf
parent18c62ad4db7abfa32105b7239c8a09effcd130c9
Let ElfFile open functions take Options

Summary:
[Folly] Let `ElfFile` open functions take a single builder-style composite `Options` argument v.s. taking a sequence of individual arguments one for each option.

Right now there is only one option but it is possible to add more in the future.

While here, rename and invert `readOnly` to `writable`.

Reviewed By: vitaut

Differential Revision: D18740699

fbshipit-source-id: 6fb016f731bf46a1b4ac6b2efcea739f6261818a
hphp/tools/debug-parser/dwarfstate.cpp