| commit | 7c6142b145d3a4adc85c4cd36d34782108bab189 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Fri, 8 May 2020 06:39:52 +0000 (7 23:39 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 8 May 2020 06:54:09 +0000 (7 23:54 -0700) | ||
| tree | b57b53d60b7e53de6bab03cab78fdf30fc43f764 | treesnapshot (tar.gz zip) |
| parent | 56bbfb0b840ceada830231ddc09b65dd7a77cb9c | commitdiff |
tests embody current bugs with duplicate names
Summary:
ClientIdeIncremental and Naming_provider are currently buggy: they don't handle duplicate names. Scenario:
1. file1.php declares symbol Foo
2. I copy file1.php to file2.php. Now the symbol Foo is defined twice.
3. I delete file1.php. Now the symbol Foo should be defined only in file2.php
The bug is that, after step 3, we currently say that the symbol Foo isn't declared at all.
I'm writing these tests now to embody the current buggy behavior. That way, when I fix it, we'll see the tests work properly.
Reviewed By: arxanas
Differential Revision: D21367492
fbshipit-source-id: e9ebddee455032eb705f3596b3850d6f69c1cc3a
Summary:
ClientIdeIncremental and Naming_provider are currently buggy: they don't handle duplicate names. Scenario:
1. file1.php declares symbol Foo
2. I copy file1.php to file2.php. Now the symbol Foo is defined twice.
3. I delete file1.php. Now the symbol Foo should be defined only in file2.php
The bug is that, after step 3, we currently say that the symbol Foo isn't declared at all.
I'm writing these tests now to embody the current buggy behavior. That way, when I fix it, we'll see the tests work properly.
Reviewed By: arxanas
Differential Revision: D21367492
fbshipit-source-id: e9ebddee455032eb705f3596b3850d6f69c1cc3a