| commit | 7c612345d0c9322376afdaf7156c005134083b44 | |
| author | Michael O'Farrell <michaelofarrell@fb.com> | |
| Wed, 17 Aug 2022 15:06:23 +0000 (17 08:06 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 17 Aug 2022 15:06:23 +0000 (17 08:06 -0700) | ||
| tree | 8af109513d17b5ff48d5cd6d45a53457d1484763 | treesnapshot (tar.gz zip) |
| parent | 12d9b8c0578cc8345170791ce167f6ce115790f2 | commitdiff |
Defer warning until heap walks are complete
Summary:
Make objprof defer issuing warnings until after it finishes iterating the heap.
Raising warnings may reenter the VM, and potentially free heap objects that the
iteration is holding pointers to.
Reviewed By: arnabde03
Differential Revision: D38756837
fbshipit-source-id: f5d439ef62d538add62c3f35b52ef4fcfaf83d6a
Summary:
Make objprof defer issuing warnings until after it finishes iterating the heap.
Raising warnings may reenter the VM, and potentially free heap objects that the
iteration is holding pointers to.
Reviewed By: arnabde03
Differential Revision: D38756837
fbshipit-source-id: f5d439ef62d538add62c3f35b52ef4fcfaf83d6a
| hphp/runtime/ext/objprof/ext_objprof.cpp | diffblobblamehistory |