| commit | 7bb571760e3c5c908ef5e031571c73faab83f216 | |
| author | Tim Starling <tstarling@wikimedia.org> | |
| Wed, 21 May 2014 19:42:52 +0000 (21 12:42 -0700) | ||
| committer | JoelMarcey <joelm@fb.com> | |
| Thu, 22 May 2014 18:15:29 +0000 (22 11:15 -0700) | ||
| tree | 25cd1628ba4449193b5b4f96d17a864b8b6da4f8 | treesnapshot (tar.gz zip) |
| parent | 92edee6ca64e50f9167ff43521c40d2369ab631c | commitdiff |
Fix base runtime asserts
Summary: Many asserts were not actually functional because they were being short-circuited with assert(true || ….) logic. Some were even using assignment instead of equality.
All conditionals around these updated asserts will be NDEBUG based since the fields are only used when asserts are enabled.
Reviewed By: mwilliams, jdelong
Differential Revision: D1311333
Pulled By: @JoelMarcey
Summary: Many asserts were not actually functional because they were being short-circuited with assert(true || ….) logic. Some were even using assignment instead of equality.
All conditionals around these updated asserts will be NDEBUG based since the fields are only used when asserts are enabled.
Reviewed By: mwilliams, jdelong
Differential Revision: D1311333
Pulled By: @JoelMarcey