Ban visibility on type constants in the typechecker.
commit7a97619c121408266c33b05431124369cbc9bab6
authorAlexey Toptygin <alexeyt@fb.com>
Tue, 13 Aug 2019 08:51:29 +0000 (13 01:51 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 13 Aug 2019 08:57:46 +0000 (13 01:57 -0700)
treea351481fdaca3886afacca815961843edae213df
parent9cd920d55d694a058cd3273772c7683fde251bd3
Ban visibility on type constants in the typechecker.

Summary: We recently added experimental support for visibility on type constants. It doesn't do anything; e.g. see: P78812083 and P78849487. We forgot to ban it while it's being worked on and it accidentally snuck into www. Ban them in the typechecker (gated by the same option that bans visibility on constants).

Reviewed By: periodic1236

Differential Revision: D16780932

fbshipit-source-id: 951552028b5f669e9bc5131b8068de328b81d1b8
hphp/hack/src/parser/full_fidelity_parser_errors.ml
hphp/hack/src/parser/full_fidelity_syntax_error.ml
hphp/hack/src/parser/full_fidelity_syntax_error.mli
hphp/hack/test/full_fidelity/cases/test_class_type_const.php [new file with mode: 0644]
hphp/hack/test/full_fidelity/cases/test_class_type_const.php.errors.exp [new file with mode: 0644]
hphp/hack/test/full_fidelity/cases/test_class_type_const.php.sexp.exp [new file with mode: 0644]