| commit | 7a27fadbcfdd704c0c18667420df00169952f0a4 | |
| author | James Wu <jjwu@fb.com> | |
| Mon, 16 Apr 2018 21:16:47 +0000 (16 14:16 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 16 Apr 2018 21:19:11 +0000 (16 14:19 -0700) | ||
| tree | b9a715e7e89e7455f6b73af3b7f658576cad0f59 | treesnapshot (tar.gz zip) |
| parent | e64843910f6c1490332c30326280a4b49e03046d | commitdiff |
Only show completely untypechecked code in typecoverage
Summary:
So I'm ambivalent about this change: on one hand, it's noisy to send partially typechecked lines to the user (especially since "null" is considered partially typed, which is very unactionable).
On the other hand, it's weird if you see under 100% on your coverage percentage, but when you click the button you don't see any feedback to fix it.
IMO, I think it's good to just turn it off for now until we can fix it by using the Typed AST for type coverage.
Feedback would be appreciated!
Reviewed By: vassilmladenov
Differential Revision: D7623107
fbshipit-source-id: b8a5a586c15eee5494cf52d56d906bb43a7c3467
Summary:
So I'm ambivalent about this change: on one hand, it's noisy to send partially typechecked lines to the user (especially since "null" is considered partially typed, which is very unactionable).
On the other hand, it's weird if you see under 100% on your coverage percentage, but when you click the button you don't see any feedback to fix it.
IMO, I think it's good to just turn it off for now until we can fix it by using the Typed AST for type coverage.
Feedback would be appreciated!
Reviewed By: vassilmladenov
Differential Revision: D7623107
fbshipit-source-id: b8a5a586c15eee5494cf52d56d906bb43a7c3467
| hphp/hack/src/client/clientLsp.ml | diffblobblamehistory |