Add option to disable parameter type compatibility checks
commit79836df94a315ac75e39d35503bd202a6431d4a4
authorPaul Bissonnette <paulbiss@fb.com>
Mon, 12 Feb 2018 17:48:20 +0000 (12 09:48 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Mon, 12 Feb 2018 18:20:43 +0000 (12 10:20 -0800)
tree9388427912a76e7a2e98352acdf004c45e8a8800
parentb3d8f99eb0d7af183f7eb6db364437e875916a21
Add option to disable parameter type compatibility checks

Summary: hh_server can already do a more sophisticated version of this check (properly accounting for type aliases, and class co/contra-variance) which the simple string comparison in hhvm can't handle. An audit of hhbbc suggests we don't actually use this particular invariant anywhere, and enforcing it in the same fashion as hack would require changes to the way autoloading is observed when classes are loaded. Since it isn't adding much value add an option to suppress it.

Reviewed By: markw65

Differential Revision: D6963404

fbshipit-source-id: 0845057e64ea6cd0331feda3291cd66a64127879
13 files changed:
hphp/runtime/base/runtime-option.cpp
hphp/runtime/base/runtime-option.h
hphp/runtime/vm/class.cpp
hphp/test/quick/impl_abstract_dv_2a.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_3a.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_as.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_ia.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_id.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_io.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_is.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_sa.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_si.php.opts [new file with mode: 0644]
hphp/test/quick/impl_abstract_dv_so.php.opts [new file with mode: 0644]