| commit | 7928caa8c806c19bbf31f6bbec7767d8af581716 | |
| author | Ted Spence <tspence@fb.com> | |
| Mon, 9 Dec 2019 19:03:00 +0000 (9 11:03 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 9 Dec 2019 19:05:34 +0000 (9 11:05 -0800) | ||
| tree | 1d99bc2e30679176509e0c88bb3f8283da5fc807 | treesnapshot (tar.gz zip) |
| parent | 8586bb68ce027b67a656993e3c33901510fba4df | commitdiff |
Restore prior behavior for disk read errors when updating the naming table
Summary:
Prior to D18650162, any disk read errors were swallowed and the file would be considered empty.
This masked a certain type of problem:
* Serverless IDE adds a file to its recheck queue
* The file changes on disk
* Serverless IDE picks up that file out of its recheck queue
* Serverless IDE attempts to do work with the file, which then can sometimes throw a "file not found" error
This diff restores prior behavior but logs uncaught exceptions so we can track how often this occurs.
Reviewed By: jewelpit
Differential Revision: D18856130
fbshipit-source-id: 8986a928d970c340512cb4c7a114a1ccece30e0b
Summary:
Prior to D18650162, any disk read errors were swallowed and the file would be considered empty.
This masked a certain type of problem:
* Serverless IDE adds a file to its recheck queue
* The file changes on disk
* Serverless IDE picks up that file out of its recheck queue
* Serverless IDE attempts to do work with the file, which then can sometimes throw a "file not found" error
This diff restores prior behavior but logs uncaught exceptions so we can track how often this occurs.
Reviewed By: jewelpit
Differential Revision: D18856130
fbshipit-source-id: 8986a928d970c340512cb4c7a114a1ccece30e0b
| hphp/hack/src/client/ide_service/clientIdeIncremental.ml | diffblobblamehistory |