server_specific_files
commit78dcbc39d336ba6381e5250b9599322781db8a0e
authorLucian Wischik <ljw@fb.com>
Fri, 23 Apr 2021 18:47:45 +0000 (23 11:47 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 23 Apr 2021 18:49:19 +0000 (23 11:49 -0700)
treead10ba34de323bfb6b2cbda18d71de4e48f564ce
parent8397135a972df19f1d9d911bd18f89d2d699452e
server_specific_files

Summary:
I want to stop using IPC with monitor to communicate progress. This diff is a step towards that.

I'm going to switch to using a file "progress.<PID>.json" which the server creates and writes to, and which the client will read from. No IPC; just communication through this lock-protected file.

The client doesn't know the server's PID. It's going to have to learn about the filename of the progress file.

The client already receives a message with a related filename from the server (the "finale file" used to communicate rich exit status). This diff changes that message to be a struct, not a string. That way in the next diff we'll be able to make the message contain two filenames in a typesafe way.

Reviewed By: CatherineGasnier

Differential Revision: D27927172

fbshipit-source-id: 7e943d7de44402b32f5f83fa9290a29b3608f6c0
12 files changed:
hphp/hack/src/client/clientConnect.ml
hphp/hack/src/client/clientLsp.ml
hphp/hack/src/monitor/dune
hphp/hack/src/monitor/monitorConnection.ml
hphp/hack/src/monitor/monitorConnection.mli
hphp/hack/src/monitor/prehandoff.ml
hphp/hack/src/monitor/serverMonitor.ml
hphp/hack/src/monitor/serverProcess.ml
hphp/hack/src/server/hhServerMonitorConfig.ml
hphp/hack/src/server/serverCommandTypes.ml
hphp/hack/test/unit/informant/informant_server_lifetime_test.ml
hphp/hack/test/unit/server_tests.ml