| commit | 78a304fb11fcf071e5c539cbf3a55bdba74c5a54 | |
| author | Elizabeth Smith <elizabeths@fb.com> | |
| Fri, 15 Aug 2014 17:02:39 +0000 (15 10:02 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Fri, 15 Aug 2014 17:30:23 +0000 (15 10:30 -0700) | ||
| tree | f795141ead402aa28a91a4850afaa94b1984a28e | treesnapshot (tar.gz zip) |
| parent | 40c4ec87e996176e7e9543afeb5d0289112e5b5e | commitdiff |
Cmake fixes on windows
Summary: This fixes two issues
1. the stack size needs to be slightly larger than the requested size in the app since the check is < not <=
2. the generate embed step had entries being double created after a call to make install - keeping the generation as it's own target makes sure that the embed file is regenerated each time so double entries don't occur in the .rc file
3. when debug is on, make huge hhbc-translator.cpp compile with -Og instead of O0 to avoid "string table overflow" bug
Reviewed By: @JoelMarcey
Differential Revision: D1500173
Summary: This fixes two issues
1. the stack size needs to be slightly larger than the requested size in the app since the check is < not <=
2. the generate embed step had entries being double created after a call to make install - keeping the generation as it's own target makes sure that the embed file is regenerated each time so double entries don't occur in the .rc file
3. when debug is on, make huge hhbc-translator.cpp compile with -Og instead of O0 to avoid "string table overflow" bug
Reviewed By: @JoelMarcey
Differential Revision: D1500173
| CMake/HPHPCompiler.cmake | diffblobblamehistory | |
| CMake/HPHPFunctions.cmake | diffblobblamehistory | |
| hphp/hhvm/CMakeLists.txt | diffblobblamehistory | |
| hphp/runtime/CMakeLists.txt | diffblobblamehistory |