| commit | 7895c9bb4783bc53d9bdb7e71b2a7f6e1eb80833 | |
| author | Kasper Kopec <kasper@fb.com> | |
| Mon, 6 Feb 2017 23:23:47 +0000 (6 15:23 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 6 Feb 2017 23:29:42 +0000 (6 15:29 -0800) | ||
| tree | c694af451dbbd3f884b061d371d340c3cd84f9a6 | treesnapshot (tar.gz zip) |
| parent | 8e19bb33feba5e63583bf9a85e130109c67f8264 | commitdiff |
Fix bug with identify symbol for static property declarations
Summary:
For static properties, "property_name" can come both with, and without a "$" in
front, depending on whether it comes from the declaration or usage place.
Normalizing it to always use whatever the map we look it up in expects.
Reviewed By: oulgen
Differential Revision: D4465061
fbshipit-source-id: 67897219b9eaa8ff050a22278b4d470e249b934a
Summary:
For static properties, "property_name" can come both with, and without a "$" in
front, depending on whether it comes from the declaration or usage place.
Normalizing it to always use whatever the map we look it up in expects.
Reviewed By: oulgen
Differential Revision: D4465061
fbshipit-source-id: 67897219b9eaa8ff050a22278b4d470e249b934a
| hphp/hack/src/server/serverSymbolDefinition.ml | diffblobblamehistory | |
| hphp/hack/test/identify_symbol/static_property2.flags | [new file with mode: 0644] | blob |
| hphp/hack/test/identify_symbol/static_property2.php | [new file with mode: 0644] | blob |
| hphp/hack/test/identify_symbol/static_property2.php.exp | [new file with mode: 0644] | blob |