| commit | 783dba3cfad604adedac570b5da39c85a62f4f9a | |
| author | Rick Lavoie <rlavoie@fb.com> | |
| Sun, 2 Aug 2020 18:07:43 +0000 (2 11:07 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sun, 2 Aug 2020 18:10:27 +0000 (2 11:10 -0700) | ||
| tree | 82f816db2066d1cedcd24ea90fdeaacb2da5e59d | treesnapshot (tar.gz zip) |
| parent | a95e1f715406144f62ca1bd1a8fe4dd07c2f3df7 | commitdiff |
Set EvalLowStaticArrays to false in the correct place for repo building
Summary:
HHBBC was forcing EvalLowStaticArrays to be false right
before running (we don't want low-mem arrays during HHBBC because
we'll run out of low-mem). However this is much too late because a
large number of arrays will have been created before HHBBC runs (since
EvalLowStaticArrays defaults to true, they'll be put into low
mem). Instead set it right when the compiler starts up, before
anything is even parsed.
Reviewed By: leikahing
Differential Revision: D22890523
fbshipit-source-id: ccd62ab3da23716c06090182c8348e4ddad1f2c4
Summary:
HHBBC was forcing EvalLowStaticArrays to be false right
before running (we don't want low-mem arrays during HHBBC because
we'll run out of low-mem). However this is much too late because a
large number of arrays will have been created before HHBBC runs (since
EvalLowStaticArrays defaults to true, they'll be put into low
mem). Instead set it right when the compiler starts up, before
anything is even parsed.
Reviewed By: leikahing
Differential Revision: D22890523
fbshipit-source-id: ccd62ab3da23716c06090182c8348e4ddad1f2c4
| hphp/compiler/compiler.cpp | diffblobblamehistory | |
| hphp/hhbbc/main.cpp | diffblobblamehistory | |
| hphp/hhbbc/whole-program.cpp | diffblobblamehistory |