| commit | 77fec6539d17b3ec1adf7ec39656b238b77e8f7f | |
| author | Joseph Griego <jgriego@fb.com> | |
| Mon, 21 Sep 2020 15:43:29 +0000 (21 08:43 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 21 Sep 2020 15:47:30 +0000 (21 08:47 -0700) | ||
| tree | 6df48d87093936661a21df97094ca6ffb85208a4 | treesnapshot (tar.gz zip) |
| parent | a21324cd0f9ff58a1d24874bbe50799e8560753f | commitdiff |
Bring minstr-effects up to date
Summary:
We no longer do falsey promotion so some of these cases are silly.
Also the case for SetElem on a string is wrong--the return value is static but
the base is not--but this doesn't matter because below we immediate promote the
base type back to counted.
Reviewed By: ricklavoie
Differential Revision: D23771367
fbshipit-source-id: 6589200585428d6f1fc27b8e5629228078938fa6
Summary:
We no longer do falsey promotion so some of these cases are silly.
Also the case for SetElem on a string is wrong--the return value is static but
the base is not--but this doesn't matter because below we immediate promote the
base type back to counted.
Reviewed By: ricklavoie
Differential Revision: D23771367
fbshipit-source-id: 6589200585428d6f1fc27b8e5629228078938fa6
| hphp/runtime/test/minstr.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/minstr-effects.cpp | diffblobblamehistory |