| commit | 7797cc1fab4ad303771a63acf0ae513edf79f50f | |
| author | Alex Malyshev <alexanderm@fb.com> | |
| Tue, 15 Apr 2014 01:31:16 +0000 (14 18:31 -0700) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Tue, 15 Apr 2014 16:30:20 +0000 (15 09:30 -0700) | ||
| tree | 5fc9129ae3a79c08cd8618c2d58422cfb178f0c9 | treesnapshot (tar.gz zip) |
| parent | 9886de4a25a921d9c9c6f3373e78ed838d2e4195 | commitdiff |
Add hacky destructor to UConverter to prevent infinite recursion
IntlUConverter is the native data for UConverter, and ~IntlUConverter
runs user callbacks that ultimately access the UConverter ObjectData,
which will rerun ~ObjectData and we go into a cycle. Run the callbacks
in UConverter::__destruct instead.
Breaks compat with PHP5, as UConverter is not supposed to have a
destructor defined. Not intended to be permanent.
The real fix is to have a better story with how native data objects are
destroyed. Mandating that they always get destroyed after their
associated ObjectData isn't going to work if we want to fully match PHP5.
Reviewed By: @ptarjan
Differential Revision: D1273255
IntlUConverter is the native data for UConverter, and ~IntlUConverter
runs user callbacks that ultimately access the UConverter ObjectData,
which will rerun ~ObjectData and we go into a cycle. Run the callbacks
in UConverter::__destruct instead.
Breaks compat with PHP5, as UConverter is not supposed to have a
destructor defined. Not intended to be permanent.
The real fix is to have a better story with how native data objects are
destroyed. Mandating that they always get destroyed after their
associated ObjectData isn't going to work if we want to fully match PHP5.
Reviewed By: @ptarjan
Differential Revision: D1273255