Add comments to some of the debugger code to aid in understanding it more clearly...
commit76db66ec82043304f9e33833f51a0fe3f459ce62
authorMike Magruder <mikemag@fb.com>
Fri, 19 Apr 2013 04:53:39 +0000 (18 21:53 -0700)
committerSara Golemon <sgolemon@fb.com>
Tue, 23 Apr 2013 16:52:57 +0000 (23 09:52 -0700)
tree2490bc45b58cbd444c3f32e57fdf6c79c78113ac
parent9a8b0d3ba444581355a1758018573511049a5fc0
Add comments to some of the debugger code to aid in understanding it more clearly, plus minor code cleanup.

Add a lot of comments to the debugger based on my current understanding of it. These may change in the future as we learn more, but they're helpful right now.

Also moved a few small things around in the code to clarify their purpose or scope. I.e., making a few things private, renaming a few functions, etc. No real logic changes, though. Also minor dead code removal. Also a few lint errors.
13 files changed:
hphp/runtime/base/types.h
hphp/runtime/eval/debugger/break_point.h
hphp/runtime/eval/debugger/cmd/cmd_break.cpp
hphp/runtime/eval/debugger/debugger.cpp
hphp/runtime/eval/debugger/debugger.h
hphp/runtime/eval/debugger/debugger_command.h
hphp/runtime/eval/debugger/debugger_proxy.cpp
hphp/runtime/eval/debugger/debugger_proxy.h
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/debugger_hook.cpp
hphp/runtime/vm/debugger_hook.h
hphp/runtime/vm/func_inline.h
hphp/runtime/vm/unit.cpp