Push Rc out of RelativePath
commit75a32d816c5e49e378af94a3a775464505668919
authorJake Bailey (Hacklang) <jakebailey@fb.com>
Mon, 28 Oct 2019 17:41:01 +0000 (28 10:41 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Mon, 28 Oct 2019 17:43:10 +0000 (28 10:43 -0700)
treef55aba6756abb444ee1a12a3a47667e00ef81291
parent48c3897a3da3ce203d7373992204361f36b88c04
Push Rc out of RelativePath

Summary: Building ref-counting into the private implementation of RelativePath forces the consumer to pay for an additional indirection, whether they need it or not. It's better to let the consumer decide whether they need reference counting so that they can use Rc/RcOc only when they are needed.

Reviewed By: shiqicao

Differential Revision: D18090912

fbshipit-source-id: 4d9bf05eab2c23544667742da88f05f3067d673a
16 files changed:
hphp/hack/Cargo.lock
hphp/hack/src/decl/Cargo.toml
hphp/hack/src/decl/direct_decl_parser.rs
hphp/hack/src/decl/rust_decl_ffi.rs
hphp/hack/src/facts/Cargo.toml
hphp/hack/src/facts/facts_parser.rs
hphp/hack/src/hh_oxidize/convert_type.ml
hphp/hack/src/name_index/sqlite/file_infos.rs
hphp/hack/src/oxidized/gen/file_info.rs
hphp/hack/src/oxidized/manual/pos.rs
hphp/hack/src/oxidized/manual/relative_path.rs
hphp/hack/src/parser/declaration_parser.rs
hphp/hack/src/parser/indexed_source_text.rs
hphp/hack/src/parser/lowerer.rs
hphp/hack/src/parser/mode_parser.rs
hphp/hack/src/parser/source_text.rs