| commit | 7487fde57be82d5826885a3b492474d0bcf50bc8 | |
| author | Rick Lavoie <rlavoie@fb.com> | |
| Thu, 25 Aug 2016 15:22:13 +0000 (25 08:22 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Thu, 25 Aug 2016 15:34:03 +0000 (25 08:34 -0700) | ||
| tree | c9eed648b8d2a0ab7cec0eba029b276aa41ab0f1 | treesnapshot (tar.gz zip) |
| parent | f50b14d01fcd14d4aa7ae55a8fe479e62af8a2cb | commitdiff |
Remove type from DecRefProfile key
Summary:
DecRefProfile is used to try to estimate whether a particular DecRef is likely
to result in a release. Part of the key used to identify particular profiler
instances is the type of the SSATmp being dec-refed. However, the type of a
SSATmp can change from profiling translations to optimized translations
(particularily if type predictions are inserted). As a result, we can lose the
profiling information about some DecRefs in the process. Remove the type
component of the key to avoid this loss of data.
Reviewed By: ottoni
Differential Revision: D3758581
fbshipit-source-id: 5596a387424c4373f1e226d9ddd8dbef93210ada
Summary:
DecRefProfile is used to try to estimate whether a particular DecRef is likely
to result in a release. Part of the key used to identify particular profiler
instances is the type of the SSATmp being dec-refed. However, the type of a
SSATmp can change from profiling translations to optimized translations
(particularily if type predictions are inserted). As a result, we can lose the
profiling information about some DecRefs in the process. Remove the type
component of the key to avoid this loss of data.
Reviewed By: ottoni
Differential Revision: D3758581
fbshipit-source-id: 5596a387424c4373f1e226d9ddd8dbef93210ada
| hphp/runtime/vm/jit/irlower-refcount.cpp | diffblobblamehistory |