Make X64Assembler short-lived
commit7234c5959308e876166ff357ac46a2da49b4f8df
authorOwen Yamauchi <oyamauchi@fb.com>
Thu, 29 Aug 2013 18:33:37 +0000 (29 11:33 -0700)
committerSara Golemon <sgolemon@fb.com>
Fri, 6 Sep 2013 02:39:51 +0000 (5 19:39 -0700)
tree9b0c74cb69198a3be79bd45e9e792c1c9d4b3db4
parentde2863dcd0075aa5490b98648315c4fefb8dff08
Make X64Assembler short-lived

This is a wide-ranging refactor. We should not have long-lived (i.e.
member) X64Assemblers anymore.

A couple of these changes are non-mechanical, and I'll point them out in
inline comments.

There are a couple things left to do:

- CodeGenerator still has member assemblers. We'll need to apply similar
  changes there, and it's just a ton of functions. I'm leaving that for
  a separate diff.

- This gets us closer to being able to remove the frontier(), base(),
  etc. member functions from X64Assembler, which will be the forcing
  function to finally separate CodeBlock concerns from assembler
  concerns.

Differential Revision: D950811
13 files changed:
hphp/runtime/vm/debug/elfwriter.cpp
hphp/runtime/vm/jit/code-gen.cpp
hphp/runtime/vm/jit/code-gen.h
hphp/runtime/vm/jit/collector.cpp
hphp/runtime/vm/jit/srcdb.cpp
hphp/runtime/vm/jit/translator-x64-internal.h
hphp/runtime/vm/jit/translator-x64.cpp
hphp/runtime/vm/jit/translator-x64.h
hphp/runtime/vm/jit/unique-stubs-x64.cpp
hphp/util/asm-x64.cpp
hphp/util/asm-x64.h
hphp/util/data-block.h
hphp/util/test/asm.cpp