| commit | 70f7a4a2edb0f142588d04332edbf76066fe8187 | |
| author | James Wu <jjwu@fb.com> | |
| Thu, 11 Feb 2021 18:24:48 +0000 (11 10:24 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 11 Feb 2021 18:30:17 +0000 (11 10:30 -0800) | ||
| tree | 33e104064e2ad046534990917113c1b45cead9c5 | treesnapshot (tar.gz zip) |
| parent | 88435507363df69d7d7f60fb3bd5625f95658753 | commitdiff |
Function calls
Summary:
This adds 3 new checks:
- Readonly function calls need to have args subtype
- Function calls that return readonly need to be wrapped in readonly
- Readonly expressions can only call readonly methods
Reviewed By: zilberstein
Differential Revision: D26377896
fbshipit-source-id: 2b4eeececc3c67253ad09deedd14e16adc51a5ea
Summary:
This adds 3 new checks:
- Readonly function calls need to have args subtype
- Function calls that return readonly need to be wrapped in readonly
- Readonly expressions can only call readonly methods
Reviewed By: zilberstein
Differential Revision: D26377896
fbshipit-source-id: 2b4eeececc3c67253ad09deedd14e16adc51a5ea
13 files changed:
| hphp/hack/src/errors/error_codes.ml | diffblobblamehistory | |
| hphp/hack/src/errors/errors.ml | diffblobblamehistory | |
| hphp/hack/src/errors/errors.mli | diffblobblamehistory | |
| hphp/hack/src/oxidized/gen/error_codes.rs | diffblobblamehistory | |
| hphp/hack/src/typing/tast_check/readonly_check.ml | diffblobblamehistory | |
| hphp/hack/test/typecheck/readonly/args.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/readonly/args.php.exp | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/readonly/basics.php | diffblobblamehistory | |
| hphp/hack/test/typecheck/readonly/basics.php.exp | diffblobblamehistory | |
| hphp/hack/test/typecheck/readonly/call.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/readonly/call.php.exp | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/readonly/explicit_ro_cast.php | [new file with mode: 0644] | blob |
| hphp/hack/test/typecheck/readonly/explicit_ro_cast.php.exp | [new file with mode: 0644] | blob |