| commit | 70aa5d5215587a0d175d5e939e8208b9d3fdfdab | |
| author | Kasper Kopec <kasper@fb.com> | |
| Wed, 21 Aug 2019 20:04:24 +0000 (21 13:04 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 21 Aug 2019 20:06:33 +0000 (21 13:06 -0700) | ||
| tree | 094b6ea9001941c6a652da5d9d9893ca75b0907b | treesnapshot (tar.gz zip) |
| parent | 953d01b69febb0b79c73a8cc8a658bd5a1db8fa7 | commitdiff |
impl Ocamlvalue for SyntaxError
Summary: This, as the change to `TARGETS` file shows, causes `parser_core_types` to depend on things that are OCaml related, which I thought would be a problem for non-OCaml users of this crate (see [this post](https://fb.workplace.com/groups/hhvm.users/permalink/2435105353204732/) for previous instance of such problem). But it seems to work this time? See inline comment on next diff (D16845845) for an example where it does not, and I don't really see what is the difference that triggers it.
Reviewed By: shiqicao
Differential Revision: D16845841
fbshipit-source-id: 2f641d74597b374c665caf391f91e79a060ece84
Summary: This, as the change to `TARGETS` file shows, causes `parser_core_types` to depend on things that are OCaml related, which I thought would be a problem for non-OCaml users of this crate (see [this post](https://fb.workplace.com/groups/hhvm.users/permalink/2435105353204732/) for previous instance of such problem). But it seems to work this time? See inline comment on next diff (D16845845) for an example where it does not, and I don't really see what is the difference that triggers it.
Reviewed By: shiqicao
Differential Revision: D16845841
fbshipit-source-id: 2f641d74597b374c665caf391f91e79a060ece84