| commit | 70912226fcf00f11a037c814db1cd4168252cdea | |
| author | David Snider <dizzy@fb.com> | |
| Wed, 22 Apr 2020 16:39:03 +0000 (22 09:39 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 22 Apr 2020 16:59:23 +0000 (22 09:59 -0700) | ||
| tree | cc3a6ff17de6ef60cac198984328d88fcc7be567 | treesnapshot (tar.gz zip) |
| parent | c92e1e1beb57090f49b8aa1889c016e09f5bd20c | commitdiff |
Move SimpleXMLElement away from __get and __set
Summary:
These can just be NativeProps which isn't re-entrant and generally sucks less.
I didn't implement the gating for whether properties can be accessed bc SXE is implemented in a really clowny way where prop access and the old arrayaccess stuff defers to the same impl and error handling is super nested. We should probably clean this up later.
Reviewed By: alexeyt
Differential Revision: D21029332
fbshipit-source-id: ab9a9e1062877b869a8e4ead8ccbbad1d54fc98a
Summary:
These can just be NativeProps which isn't re-entrant and generally sucks less.
I didn't implement the gating for whether properties can be accessed bc SXE is implemented in a really clowny way where prop access and the old arrayaccess stuff defers to the same impl and error handling is super nested. We should probably clean this up later.
Reviewed By: alexeyt
Differential Revision: D21029332
fbshipit-source-id: ab9a9e1062877b869a8e4ead8ccbbad1d54fc98a