| commit | 701e3c7c6f1b443656e0e5f980073409fcfc3f72 | |
| author | Sasha Manzyuk <manzyuk@fb.com> | |
| Tue, 13 Feb 2018 13:48:34 +0000 (13 05:48 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 13 Feb 2018 17:43:11 +0000 (13 09:43 -0800) | ||
| tree | d9fb1d0edf5ed470d67f2cee4f9888fdfde75e22 | treesnapshot (tar.gz zip) |
| parent | deeb640a3223faa2bc373bcd501f1eb16267a2ed | commitdiff |
Make hphp/hack/test/review.sh work in Emacs shells
Summary: The script `hphp/hack/test/review.sh` behaves funny if run in Emacs shells (started by `M-x shell`). The shell process doesn't receive any input until the user presses `RET` but then the `-n 1` seems to have the effect that `y` followed by `RET` is interpreted by bash as two characters and `RET` is received by the iteration of the loop. So, the overall effect is that the script basically skips every other test. The solution is not to use `-n 1` in dumb terminals.
Reviewed By: arxanas
Differential Revision: D6963801
fbshipit-source-id: 396ccb171b41853ae37f4203d18cc58866c94383
Summary: The script `hphp/hack/test/review.sh` behaves funny if run in Emacs shells (started by `M-x shell`). The shell process doesn't receive any input until the user presses `RET` but then the `-n 1` seems to have the effect that `y` followed by `RET` is interpreted by bash as two characters and `RET` is received by the iteration of the loop. So, the overall effect is that the script basically skips every other test. The solution is not to use `-n 1` in dumb terminals.
Reviewed By: arxanas
Differential Revision: D6963801
fbshipit-source-id: 396ccb171b41853ae37f4203d18cc58866c94383
| hphp/hack/test/review.sh | diffblobblamehistory |