| commit | 6f40a131aec3ded6cb6c5d42e9b82cf864711b68 | |
| author | Eric GELOEN <geloen.eric@gmail.com> | |
| Thu, 24 Jul 2014 14:22:30 +0000 (24 07:22 -0700) | ||
| committer | facebook-github-bot <githubbot@fb.com> | |
| Thu, 24 Jul 2014 14:30:21 +0000 (24 07:30 -0700) | ||
| tree | cf1c96b6f10c2d403b33f0f4bda4801db783397f | treesnapshot (tar.gz zip) |
| parent | faeab0be53b374c559e8ffe21f5489aa0fba2533 | commitdiff |
Fix http headers parsing + Remove unused code + Fix indentation
Summary: This PR does three things:
- Remove an unused variable in the http-client
- Fix indentation of one of my previous commit
- Fix the http headers parsing (Fixes #3241)
Regarding the fix about the http header parsing, the [RFC-2616](http://tools.ietf.org/html/rfc2616#section-4.2) specifies that the field value **MAY** be preceded by any amount of LWS, though a single SP is preferred. So, an header value not preceded by a space is valid.
Closes https://github.com/facebook/hhvm/pull/3248
Reviewed By: @JoelMarcey
Differential Revision: D1447936
Pulled By: svcscm
Summary: This PR does three things:
- Remove an unused variable in the http-client
- Fix indentation of one of my previous commit
- Fix the http headers parsing (Fixes #3241)
Regarding the fix about the http header parsing, the [RFC-2616](http://tools.ietf.org/html/rfc2616#section-4.2) specifies that the field value **MAY** be preceded by any amount of LWS, though a single SP is preferred. So, an header value not preceded by a space is valid.
Closes https://github.com/facebook/hhvm/pull/3248
Reviewed By: @JoelMarcey
Differential Revision: D1447936
Pulled By: svcscm
| hphp/runtime/base/http-client.cpp | diffblobblamehistory | |
| hphp/runtime/base/http-stream-wrapper.cpp | diffblobblamehistory |