| commit | 6f177eee054ca552dfccc1fb9eb1a0f4609025bd | |
| author | Jan Oravec <jan@fb.com> | |
| Wed, 26 Feb 2020 11:17:09 +0000 (26 03:17 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 26 Feb 2020 11:19:57 +0000 (26 03:19 -0800) | ||
| tree | df8810a4368cd90407e890760eba8c59dda22c70 | treesnapshot (tar.gz zip) |
| parent | 8a0a9ba0d5b0d1bd6b4656e829a388952cc5d951 | commitdiff |
Raise too many args if unpacking too many args
Summary:
prepareFuncEntry() was not observing too many arguments condition when a callee
was called with variadic arguments. Fix this by unifying the state observed by
prepareFuncEntry(). We no longer have untrimmed and trimmed state. The new
expectations are that there are up to func->numNonVariadicParams() arguments on
the stack and all other arguments are packed into a varray that can't be empty.
This matches JIT prologue behavior (except of emptiness).
Reviewed By: ricklavoie
Differential Revision: D20088967
fbshipit-source-id: 0f1ab96796d5e90ddea6267e6d0e495cdda6cb36
Summary:
prepareFuncEntry() was not observing too many arguments condition when a callee
was called with variadic arguments. Fix this by unifying the state observed by
prepareFuncEntry(). We no longer have untrimmed and trimmed state. The new
expectations are that there are up to func->numNonVariadicParams() arguments on
the stack and all other arguments are packed into a varray that can't be empty.
This matches JIT prologue behavior (except of emptiness).
Reviewed By: ricklavoie
Differential Revision: D20088967
fbshipit-source-id: 0f1ab96796d5e90ddea6267e6d0e495cdda6cb36