| commit | 6eca31d3aea42db7cacf7d62779539088df57126 | |
| author | Vassil Mladenov <vmladenov@fb.com> | |
| Mon, 22 Mar 2021 18:45:08 +0000 (22 11:45 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 22 Mar 2021 18:49:40 +0000 (22 11:49 -0700) | ||
| tree | a8b224617088c0e2fb4093a15aa072a6fdcd4180 | treesnapshot (tar.gz zip) |
| parent | 5b8c71a85f1efa0a9090b93932b337c050ac26eb | commitdiff |
Add autocomplete complete support for enum atoms
Summary:
Given
```
function f<T>(<<__Atom>> HH\MemberOf<EE, T> $m): void {}
```
This is meant trigger autocomplete on `f#` with nearly the same results as `EE::`. I just send back the constants of the enum class, ignoring the `::class` constant which is used for classname (not relevant to atoms).
The enum atom rewriting works out nicely, because when we see `f#AUTO332` the parser guarantees that we're in an `Aast.Call` node, so I can just look at `Call` nodes where the first argument is an `EnumAtom`.
Reviewed By: Wilfred
Differential Revision: D27145618
fbshipit-source-id: f7a68638c98e250f232eb804233407030d31c7b5
Summary:
Given
```
function f<T>(<<__Atom>> HH\MemberOf<EE, T> $m): void {}
```
This is meant trigger autocomplete on `f#` with nearly the same results as `EE::`. I just send back the constants of the enum class, ignoring the `::class` constant which is used for classname (not relevant to atoms).
The enum atom rewriting works out nicely, because when we see `f#AUTO332` the parser guarantees that we're in an `Aast.Call` node, so I can just look at `Call` nodes where the first argument is an `EnumAtom`.
Reviewed By: Wilfred
Differential Revision: D27145618
fbshipit-source-id: f7a68638c98e250f232eb804233407030d31c7b5
16 files changed: