Refactor HashCollection to use MixedArray find helpers
commit6df3d631e0505de7e492b68cd545391abcb6be9b
authorEdwin Smith <smith@fb.com>
Mon, 8 May 2017 17:46:22 +0000 (8 10:46 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Mon, 8 May 2017 17:59:33 +0000 (8 10:59 -0700)
tree33e3e9bfa4a886590c4360b195f3cb84171bac75
parentedba151da88044bf1da9e5a5235b839a0188bff0
Refactor HashCollection to use MixedArray find helpers

Summary:
Avoid having two implementations of essentially the same
functions. The version of findForInsert() used by HashCollection
reused Tombstone slots, but MixedArray doesn't; so this subtly
changes HC's findForInsert behavior.

Other than that, this just moves code around to preserve
inlining where we did it before.

Reviewed By: markw65

Differential Revision: D5019985

fbshipit-source-id: e118a7451f7366af143511f3264881c434370674
hphp/runtime/base/mixed-array-defs.h
hphp/runtime/base/mixed-array.cpp
hphp/runtime/ext/collections/hash-collection.cpp
hphp/runtime/ext/collections/hash-collection.h