| commit | 6dc0b2622f80fba42cbac0b9dcc1ed65cd70d276 | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Mon, 3 Feb 2014 00:18:45 +0000 (2 16:18 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Thu, 6 Feb 2014 19:25:11 +0000 (6 11:25 -0800) | ||
| tree | 89a3b37ead185bd4e1db0ea8fed7457ad4c8ef6e | treesnapshot (tar.gz zip) |
| parent | e4111e5abfa7539d0520f5f5df754a64e9e1a45d | commitdiff |
Fix bugs in query op predicates introduced by removal of JmpIs{N,}Type
This fusion was apparently actually happening after all, at
least with hhbbc turned on. Maybe we'll want to implement something
like it at some point (or use a generic branch fusion thing), but
right now it is probably best to leave it off, because it wasn't
implemented in jump-opts and the REQ_BIND_JMPCC would end up in
astubs, which seems worse than one extra setcc and test opcode.
Reviewed By: @bertmaher
Differential Revision: D1155023
This fusion was apparently actually happening after all, at
least with hhbbc turned on. Maybe we'll want to implement something
like it at some point (or use a generic branch fusion thing), but
right now it is probably best to leave it off, because it wasn't
implemented in jump-opts and the REQ_BIND_JMPCC would end up in
astubs, which seems worse than one extra setcc and test opcode.
Reviewed By: @bertmaher
Differential Revision: D1155023
| hphp/runtime/vm/jit/ir.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/ir.h | diffblobblamehistory | |
| hphp/runtime/vm/jit/simplifier.cpp | diffblobblamehistory |