| commit | 6c8f5943384852fb3b11c79f4ae96580ea33ef08 | |
| author | Millie Chen <milliechen@fb.com> | |
| Thu, 3 Feb 2022 23:05:44 +0000 (3 15:05 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 3 Feb 2022 23:07:49 +0000 (3 15:07 -0800) | ||
| tree | 08df7643416f0d03cc24333dd13de2b9cf2faa02 | treesnapshot (tar.gz zip) |
| parent | c88601c256ac99d86114eb275cbc721e7b5840f9 | commitdiff |
Return Option instead of Result with unit error
Summary: Address [this comment](https://www.internalfb.com/diff/D33981891 (https://github.com/facebook/hhvm/commit/65c92181e14aeeda6247c9e55bfd7006c40a1a78)?dst_version_fbid=1476545829405973&transaction_fbid=530399504808630), though it seems like the function is unused in the codebase. I wonder if we should just remove it.
Reviewed By: edwinsmith
Differential Revision: D33984789
fbshipit-source-id: f614b3abb5f39781b0f74fde4cb376f9ab088d93
Summary: Address [this comment](https://www.internalfb.com/diff/D33981891 (https://github.com/facebook/hhvm/commit/65c92181e14aeeda6247c9e55bfd7006c40a1a78)?dst_version_fbid=1476545829405973&transaction_fbid=530399504808630), though it seems like the function is unused in the codebase. I wonder if we should just remove it.
Reviewed By: edwinsmith
Differential Revision: D33984789
fbshipit-source-id: f614b3abb5f39781b0f74fde4cb376f9ab088d93
| hphp/hack/src/utils/line_break_map.rs | diffblobblamehistory | |
| hphp/hack/src/utils/test/line_break_map_tests.rs | diffblobblamehistory |