Surround highlighted identifier with backticks to allow nested markdown formatting...
commit6b03bfa2cc89c429d7f69d8624b2be0c65e145fd
authorMichael Christensen <michristensen@fb.com>
Fri, 11 Sep 2020 16:49:42 +0000 (11 09:49 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 11 Sep 2020 16:56:53 +0000 (11 09:56 -0700)
tree395f05f3829c6eb45e9215ad59b8ddbf0fe697e4
parentb42304d66cb34f66fd306bed8fbbcec11cafbef2
Surround highlighted identifier with backticks to allow nested markdown formatting in message

Summary:
Augments an existing error message to surround an identifier with backticks in addition to any character highlighting that may be embedded. This is allowed because D23621091 adds support for nested Markdown delimiters.

Before:

{F333431500}

After (notice the first supporting message):

{F333403093}

Reviewed By: Wilfred

Differential Revision: D23627810

fbshipit-source-id: 64c551de46c2cfcfee1d136431298b0c9e7ad551
12 files changed:
hphp/hack/src/errors/errors.ml
hphp/hack/test/integration/common_tests.py
hphp/hack/test/integration_ml/test_capitalization.ml
hphp/hack/test/typecheck/capitalization1.php.exp
hphp/hack/test/typecheck/capitalization2.php.exp
hphp/hack/test/typecheck/capitalization3.php.exp
hphp/hack/test/typecheck/capitalization4.php.exp
hphp/hack/test/typecheck/capitalization5.php.exp
hphp/hack/test/typecheck/capitalization6.php.exp
hphp/hack/test/typecheck/capitalization7.php.exp
hphp/hack/test/typecheck/naming_fail_test10.php.exp
hphp/hack/test/unit/naming/localmem_naming_tests.ml