| commit | 69f3b813a1241bde39116597fed4987012465021 | |
| author | Steve Walk <steve.walk@cavium.com> | |
| Fri, 7 Dec 2018 03:29:44 +0000 (6 19:29 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 7 Dec 2018 03:32:31 +0000 (6 19:32 -0800) | ||
| tree | 271bb7012ec8271080634b9d14e90207ba9b7baf | treesnapshot (tar.gz zip) |
| parent | 8be32d767c6a4b9a8a06ebc5ee1a5d97748dc658 | commitdiff |
predicate test to avoid issues on aarch64 (#8398)
Summary:
This commit https://github.com/facebook/hhvm/commit/c02ec574cdae149eed5d1795b2349428ecac37c2
broke the regression suite on aarch64 hosts. The first transformation removes a form expected by
the service requests code. An internal assert correctly detected this condition.
/data2/swalk/play.120518a/hhvm/hphp/runtime/vm/jit/service-requests.cpp:280: HPHP::jit::FPInvOffset HPHP::jit::svcreq::extract_spoff(HPHP::jit::TCA): assertion `false && "Expected an instruction that offsets SP"' failed.
Core dumped: Aborted
A full MOP was run. The results reflected the new baseline as documented in issue #8396.
This fixes issue #8397
Pull Request resolved: https://github.com/facebook/hhvm/pull/8398
Differential Revision: D13362114
Pulled By: fredemmott
fbshipit-source-id: ce4b1cfb1f7b94c01355e7b983a47fccee3b7a48
Summary:
This commit https://github.com/facebook/hhvm/commit/c02ec574cdae149eed5d1795b2349428ecac37c2
broke the regression suite on aarch64 hosts. The first transformation removes a form expected by
the service requests code. An internal assert correctly detected this condition.
/data2/swalk/play.120518a/hhvm/hphp/runtime/vm/jit/service-requests.cpp:280: HPHP::jit::FPInvOffset HPHP::jit::svcreq::extract_spoff(HPHP::jit::TCA): assertion `false && "Expected an instruction that offsets SP"' failed.
Core dumped: Aborted
A full MOP was run. The results reflected the new baseline as documented in issue #8396.
This fixes issue #8397
Pull Request resolved: https://github.com/facebook/hhvm/pull/8398
Differential Revision: D13362114
Pulled By: fredemmott
fbshipit-source-id: ce4b1cfb1f7b94c01355e7b983a47fccee3b7a48
| hphp/runtime/vm/jit/vasm-simplify.cpp | diffblobblamehistory |