| commit | 69869ce4a20d1762493802051ec08ebf2390dee2 | |
| author | Robert Geva <ryg@fb.com> | |
| Sat, 15 Dec 2018 04:33:59 +0000 (14 20:33 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Sat, 15 Dec 2018 04:36:24 +0000 (14 20:36 -0800) | ||
| tree | 77c5f8c568b48cd550891be87194ad31ccfc4f33 | treesnapshot (tar.gz zip) |
| parent | 1e2cf667a7ea1be2d2891bca04b8ba396238ffce | commitdiff |
check the return value of endInlining in conjureEndInlining
Summary:
endInliing is returning a bool, and conjureEndInlining was ignoring
the return value. The bool indicates whether we successed in generating code
for the region. If we didn't, conjureEndInlining should return false and get
irGenInlineRegion also to return a nullptr.
Reviewed By: ottoni
Differential Revision: D13455581
fbshipit-source-id: 8dfa4b0ae1a7ed133f19fb7b5f65a7b6929d4398
Summary:
endInliing is returning a bool, and conjureEndInlining was ignoring
the return value. The bool indicates whether we successed in generating code
for the region. If we didn't, conjureEndInlining should return false and get
irGenInlineRegion also to return a nullptr.
Reviewed By: ottoni
Differential Revision: D13455581
fbshipit-source-id: 8dfa4b0ae1a7ed133f19fb7b5f65a7b6929d4398
| hphp/runtime/vm/jit/irgen-inlining.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/irgen.h | diffblobblamehistory | |
| hphp/runtime/vm/jit/translate-region.cpp | diffblobblamehistory |