| commit | 680a86e0422e4d81cc223b0529c6d0f65eb59af6 | |
| author | mwilliams <mwilliams@fb.com> | |
| Tue, 11 Oct 2011 19:24:16 +0000 (11 12:24 -0700) | ||
| committer | macvicar <macvicar@fb.com> | |
| Tue, 18 Oct 2011 00:48:29 +0000 (17 17:48 -0700) | ||
| tree | a04df8830338d50bb4c2d1b280ad19bff4a3b3a5 | treesnapshot (tar.gz zip) |
| parent | 3c4b4b6bb1960f156e5dfeb14d978e80ca12f7d9 | commitdiff |
[Fix] Only optimize dynamicNamedCall when its known to be dynamic
Summary: There was a small optimization for the case of a dynamic call through
a derived-from-redeclared class. But its only valid when the call is known to be
dynamic. The objCall flag is used to indicate dynamic (>0) possibly-dynamic
(<0), and static (0), but we were just testing for non-zero. Replace with a test
for >0 instead.
Test Plan: fast_tests slow_tests
Reviewers: myang, kma
Reviewed By: myang
CC: ps, mwilliams, myang
Differential Revision: 342326
Summary: There was a small optimization for the case of a dynamic call through
a derived-from-redeclared class. But its only valid when the call is known to be
dynamic. The objCall flag is used to indicate dynamic (>0) possibly-dynamic
(<0), and static (0), but we were just testing for non-zero. Replace with a test
for >0 instead.
Test Plan: fast_tests slow_tests
Reviewers: myang, kma
Reviewed By: myang
CC: ps, mwilliams, myang
Differential Revision: 342326
| src/compiler/expression/simple_function_call.cpp | diffblobblamehistory | |
| src/test/test_code_run.cpp | diffblobblamehistory |