push parsing, naming and decling errors
commit6805e3fbe5e5ced2cd3ecbf1ab49418839d81f7f
authorCatherine Gasnier <catg@fb.com>
Fri, 9 Jul 2021 17:22:38 +0000 (9 10:22 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 9 Jul 2021 18:23:20 +0000 (9 11:23 -0700)
tree826f19c69da26cfeeeb3521d2042763a8ff3baa7
parentf30177f8eee0dc7832e8e880661f19df6a558ee0
push parsing, naming and decling errors

Summary: This requires to adapt the diagnostic pusher to also keep track of phases: we don't want "no errors" in Typing phase to erase errors in previous phases.

Reviewed By: ljw1004

Differential Revision: D29454477

fbshipit-source-id: 019dc1b320cf6cafd1efab1ac8d22ff6a59e9e64
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/server/diagnostic_pusher.ml
hphp/hack/src/server/diagnostic_pusher.mli
hphp/hack/src/server/serverTypeCheck.ml
hphp/hack/src/typing/typing_check_service.ml
hphp/hack/src/utils/collections/reordered_argument_collections.ml
hphp/hack/test/unit/ide/diagnostic_pusher_test.ml
hphp/hack/test/unit/utils/diagnostic_subscription_test.ml
hphp/hack/test/unit/utils/errors_test.ml