| commit | 674ec250441a18d4aaf5adc6bb30ec27e0f918dc | |
| author | Mark Williams <mwilliams@fb.com> | |
| Fri, 5 Aug 2016 19:47:15 +0000 (5 12:47 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Fri, 5 Aug 2016 20:07:02 +0000 (5 13:07 -0700) | ||
| tree | 90ba00a2ab67b9317263186bfb6e7509c171e62c | treesnapshot (tar.gz zip) |
| parent | 9daab51e359440d7757c9a03b17f7e69be26ebe6 | commitdiff |
Fix issue with calling a unique, non-persistent method
Summary:
D3615610 lost a check that non-persistent unique classes were actually
loaded. This allowed static methods to execute without the class being
defined, which in turn allowed objects of the class to be created, and
then non-static methods to be called, all without defining the class.
Reviewed By: mxw
Differential Revision: D3675397
fbshipit-source-id: 5cec72c7f16a0b9f7bbc5f18c5d99dd73b062d16
Summary:
D3615610 lost a check that non-persistent unique classes were actually
loaded. This allowed static methods to execute without the class being
defined, which in turn allowed objects of the class to be created, and
then non-static methods to be called, all without defining the class.
Reviewed By: mxw
Differential Revision: D3675397
fbshipit-source-id: 5cec72c7f16a0b9f7bbc5f18c5d99dd73b062d16
| hphp/runtime/vm/jit/irgen-call.cpp | diffblobblamehistory | |
| hphp/test/slow/compilation/fpushclsmethod-unique-volatile.php | [new file with mode: 0644] | blob |
| hphp/test/slow/compilation/fpushclsmethod-unique-volatile.php.expectf | [new file with mode: 0644] | blob |
| hphp/test/slow/compilation/fpushclsmethod-unique-volatile.php.hphp_opts | [new file with mode: 0644] | blob |
| hphp/test/slow/compilation/fpushclsmethod-unique-volatile.php.opts | [new file with mode: 0644] | blob |