Default `disable_unset_class_const` to `true` and remove
commit65c95d116f998ca640de3325e0d8adb8314618cb
authorHunter Goldstein <hgoldstein@fb.com>
Wed, 16 Feb 2022 17:31:23 +0000 (16 09:31 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 16 Feb 2022 17:33:26 +0000 (16 09:33 -0800)
tree803fdd983aa8ba67470945fcac7522a03babdc3e
parent9d3b058fc5a00639dc52464973032502e3cf6d97
Default `disable_unset_class_const` to `true` and remove

Summary: This shouldn't be allowed: it's nonsense to `unset` a value on a constant. Note that this was already a typing error, so this diff *also* removes the typechecking code that is redundant with the new parser check.

Reviewed By: vassilmladenov

Differential Revision: D34159046

fbshipit-source-id: 083a42a277c9ea2218248397af40e37b115175c7
31 files changed:
hphp/hack/src/hackc/compile/compile.rs
hphp/hack/src/hackc/compile/options.rs
hphp/hack/src/hackc/compile/options_cli.rs
hphp/hack/src/hackc/hhbc_options.ml
hphp/hack/src/hh_single_type_check.ml
hphp/hack/src/options/globalOptions.ml
hphp/hack/src/options/globalOptions.mli
hphp/hack/src/options/parserOptions.ml
hphp/hack/src/oxidized/gen/global_options.rs
hphp/hack/src/oxidized/manual/global_options_impl.rs
hphp/hack/src/oxidized_by_ref/gen/global_options.rs
hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs
hphp/hack/src/parser/lowerer/lowerer.rs
hphp/hack/src/server/serverConfig.ml
hphp/hack/src/typing/typing.ml
hphp/hack/test/rust/hhbc_options_migration_test.ml
hphp/hack/test/typecheck/const_attribute/static/HH_FLAGS
hphp/hack/test/typecheck/const_attribute/static/unset_const.php.exp
hphp/hack/test/typecheck/const_collections_cant_unset.php.exp
hphp/runtime/base/runtime-option.cpp
hphp/runtime/base/runtime-option.h
hphp/test/slow/parser/unset_class_constant.php.hphp_opts [deleted file]
hphp/test/slow/parser/unset_class_constant.php.opts [deleted file]
hphp/test/slow/parser/unset_class_constant2.php.hphp_opts [deleted file]
hphp/test/slow/parser/unset_class_constant2.php.opts [deleted file]
hphp/test/slow/parser/unset_class_constant_dim0.php.hphp_opts [deleted file]
hphp/test/slow/parser/unset_class_constant_dim0.php.opts [deleted file]
hphp/test/slow/parser/unset_class_constant_on_instance.php.hphp_opts [deleted file]
hphp/test/slow/parser/unset_class_constant_on_instance.php.opts [deleted file]
hphp/test/slow/parser/unset_class_constant_read.php.hphp_opts [deleted file]
hphp/test/slow/parser/unset_class_constant_read.php.opts [deleted file]