| commit | 6565436427d92ba27ec81302084dc87da0876649 | |
| author | Vladimir Matveev <vladima@fb.com> | |
| Thu, 28 Sep 2017 05:48:38 +0000 (27 22:48 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 28 Sep 2017 05:58:24 +0000 (27 22:58 -0700) | ||
| tree | 0054e66fb23b31c88f4029e80393da2d658ba4dd | treesnapshot (tar.gz zip) |
| parent | 4d151bf5b72f0c1da9ba1dfdd8c29245c15103f0 | commitdiff |
enable source locations
Summary:
This diff enables source locations for both HHVM and HackC. At this point semdiff ignores `.srcloc` directives so results of tests are mainly untouched however later we'll add validation for function spans and emitted srcloc directives.
Changes in semdiff are necessary to handle issue that were hidden before: semdiff crashed when parsing .hhas, then we resort to case-insensitive syntax diff and it showed that files are identical. Now when we emit source locations, semdiff still used to crash but now syntax diff did not consider files identical because of differences in source locations.
Reviewed By: aaronkroth
Differential Revision: D5921939
fbshipit-source-id: b5fd122d89adb584f64467d918b5d7c906a634fb
Summary:
This diff enables source locations for both HHVM and HackC. At this point semdiff ignores `.srcloc` directives so results of tests are mainly untouched however later we'll add validation for function spans and emitted srcloc directives.
Changes in semdiff are necessary to handle issue that were hidden before: semdiff crashed when parsing .hhas, then we resort to case-insensitive syntax diff and it showed that files are identical. Now when we emit source locations, semdiff still used to crash but now syntax diff did not consider files identical because of differences in source locations.
Reviewed By: aaronkroth
Differential Revision: D5921939
fbshipit-source-id: b5fd122d89adb584f64467d918b5d7c906a634fb
| hphp/hack/src/hhbc/hhas_lexer.mll | diffblobblamehistory | |
| hphp/hack/src/hhbc/instruction_sequence.ml | diffblobblamehistory | |
| hphp/test/run | diffblobblamehistory |