| commit | 64062cab436d89d7e00bb62619856fe666c9f7fe | |
| author | Mark Williams <mwilliams@fb.com> | |
| Mon, 23 Apr 2018 15:53:15 +0000 (23 08:53 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 23 Apr 2018 15:56:43 +0000 (23 08:56 -0700) | ||
| tree | 2dd5900260ec3b11feaa7eed78df52bfbceae943 | treesnapshot (tar.gz zip) |
| parent | e167b5d82ae52d88f6c217c740be723a5fda4dd5 | commitdiff |
Don't use c++ streams for jit serialization
Summary:
C++ streams can be slow; they're also overkill for what we're doing.
In addition, we want to be able to serialize the jit state while crashing, and apart from one hash-table that we build during serialization (which we can probably eliminate), this was the only thing thats not signal handler safe.
Reviewed By: alexeyt
Differential Revision: D7719797
fbshipit-source-id: 2d64c0874115c5b5a44eb27a32902acff6056e7b
Summary:
C++ streams can be slow; they're also overkill for what we're doing.
In addition, we want to be able to serialize the jit state while crashing, and apart from one hash-table that we build during serialization (which we can probably eliminate), this was the only thing thats not signal handler safe.
Reviewed By: alexeyt
Differential Revision: D7719797
fbshipit-source-id: 2d64c0874115c5b5a44eb27a32902acff6056e7b
| hphp/runtime/vm/jit/prof-data-serialize.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/prof-data-serialize.h | diffblobblamehistory |