| commit | 62d5ab29984d8e8f2a49566be5698241a10f3c37 | |
| author | Jake Bailey (Hacklang) <jakebailey@fb.com> | |
| Sat, 20 Oct 2018 02:37:39 +0000 (19 19:37 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Sat, 20 Oct 2018 02:40:34 +0000 (19 19:40 -0700) | ||
| tree | d4d218d0048ed5b1356d0d660598bb4da2eacc30 | treesnapshot (tar.gz zip) |
| parent | 1d9da089cd34cf7cdc48d466a5d441038fecd849 | commitdiff |
Visit shape keys in AAST visitors
Summary:
It looks like visitation of shape keys was overlooked in D6481759--these base visitors currently only visit ShapeMap values. After this change, we will visit both keys and values.
The `endo` visitor is meant to be equivalent to `map`, but should avoid allocating new nodes when unnecessary. We don't use `endo` visitors much, and the existing implementation already reallocated unconditionally, so I haven't taken the time to write a proper `endo` implementation and called out the problem with a FIXME instead.
Reviewed By: arxanas
Differential Revision: D10470531
fbshipit-source-id: 596cdaab71b46abb361eb85f6aef48a43f22e45e
Summary:
It looks like visitation of shape keys was overlooked in D6481759--these base visitors currently only visit ShapeMap values. After this change, we will visit both keys and values.
The `endo` visitor is meant to be equivalent to `map`, but should avoid allocating new nodes when unnecessary. We don't use `endo` visitors much, and the existing implementation already reallocated unconditionally, so I haven't taken the time to write a proper `endo` implementation and called out the problem with a FIXME instead.
Reviewed By: arxanas
Differential Revision: D10470531
fbshipit-source-id: 596cdaab71b46abb361eb85f6aef48a43f22e45e
| hphp/hack/src/annotated_ast/aast_defs_visitors_ancestors.ml | diffblobblamehistory |