Debugger should not lookup units
commit60284bed4dd8d850918e98c975851068304a82db
authorArnab De <arnabde@fb.com>
Wed, 29 Sep 2021 14:42:02 +0000 (29 07:42 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 29 Sep 2021 14:44:49 +0000 (29 07:44 -0700)
tree198e40768db6ce0cfe1ca889c4553484ed83f9d2
parent2c2d6126b5c6f4cb3d9c11fc6979801deeefcaf5
Debugger should not lookup units

Summary: There is no need to eagerly lookup units in order to resolve breakpoints. We can resolve breakpoints when an unit is loaded by HHVM. The current scheme works only for source line breakpoints when we have full path of the file.

Reviewed By: jeffreytan81

Differential Revision: D30997213

fbshipit-source-id: e6ab0bdccef80dcaf35c71ccce6f84ed3ef42778
hphp/runtime/ext/vsdebug/debugger.cpp
hphp/test/slow/ext_vsdebug/breakpoints.php
hphp/test/slow/ext_vsdebug/common.inc
hphp/test/slow/ext_vsdebug/conditional_bp.php
hphp/test/slow/ext_vsdebug/context.php
hphp/test/slow/ext_vsdebug/exception_bp.php
hphp/test/slow/ext_vsdebug/info.php
hphp/test/slow/ext_vsdebug/step.php
hphp/test/slow/ext_vsdebug/todebugdisplay.php
hphp/test/slow/ext_vsdebug/variables_all_types.php